Disabled global HTML escaping, while always escaping within code blocks.#87
Open
michaek wants to merge 1 commit intoevilstreak:masterfrom
Open
Disabled global HTML escaping, while always escaping within code blocks.#87michaek wants to merge 1 commit intoevilstreak:masterfrom
michaek wants to merge 1 commit intoevilstreak:masterfrom
Conversation
Author
|
Any feedback? I think the Babelmark link makes it pretty clear that escaping HTML outside a code block is unconventional for Markdown. (Not to mention that the Markdown documentation is explicit about allowing HTML.) |
|
+1 I also need [an optional flag for] markdown-js to pass through HTML markup which is in Markdown files. |
|
I found a bug with this patch, noted here. |
|
Anything new regarding HTML-support? |
|
I'm also feeling the need for this option. Any progress here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows from #34, opting to disable HTML escaping except in code blocks. I understand that it's been stated to be undesirable by the maintainers, but I think it is a more consistent implementation of Markdown.
I've added a test that mimics the handling here http://babelmark.bobtfish.net/?markdown=%3Cp%3EHTML%3C%2Fp%3E%0D%0A%0D%0A++++%3Cp%3ECode%3C%2Fp%3E&src=1&dest=2